Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazyload rss widgets #1042

Closed
2 tasks done
Meierschlumpf opened this issue Jun 10, 2023 · 4 comments
Closed
2 tasks done

Lazyload rss widgets #1042

Meierschlumpf opened this issue Jun 10, 2023 · 4 comments
Assignees
Labels
🤔 Idea Tell us your ideas 🎴 Widget

Comments

@Meierschlumpf
Copy link
Collaborator

Description

When a lot of rssfeeds are configured the loading takes pretty long. It would be great if the images of the rss widget would be lazy loaded. (Loaded after the dashboard is ready)

Please tick the boxes

@ajnart
Copy link
Owner

ajnart commented Jul 21, 2023

Need to do this soon

@ajnart ajnart self-assigned this Jul 23, 2023
@ajnart
Copy link
Owner

ajnart commented Jul 23, 2023

@Meierschlumpf ive tried this today and it seemed to only save about 1kb of space. So 1/478kb on page load. If we want to reduce page load time we should look for other improvements.

If you’re okay let’s close this. The “big” libraries should be the ones we dynamically load like the videojs one for example.

I think if you run yarn analyze it shows you what takes space and ~70% of it in just mantine stuff 🥲

@Meierschlumpf
Copy link
Collaborator Author

Yeah the thing with this issue was, that when you have added for example 10 different rss sources, that it would have to load all the images for the rss items imediately. But I know what you mean. So the lazy loading would only be related to images

@ajnart
Copy link
Owner

ajnart commented Jul 23, 2023

Yeah the thing with this issue was, that when you have added for example 10 different rss sources, that it would have to load all the images for the rss items imediately. But I know what you mean. So the lazy loading would only be related to images

Oooh you mean that. Makes sense. I thought you meant using next/dynamic to load it to reduce initial bundle size.

So the issue is most likely that we await for the return of promises to get the link to the image before displaying it. Maybe we can return a promise and let it solve itself locally? We can probably use the ‘input’ option on the trpc query to modify the data we get so that it fetches the open graph tags by itself (or parses the rss, I’m not sure how it’s done)

@github-project-automation github-project-automation bot moved this to 🆕 New in Homarr Kanban Nov 15, 2023
@Meierschlumpf Meierschlumpf closed this as not planned Won't fix, can't repro, duplicate, stale Jan 10, 2025
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Homarr Kanban Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤔 Idea Tell us your ideas 🎴 Widget
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants