Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recompute ridge_points and ridge_vertices after making regions finite #7

Open
alonfnt opened this issue Jul 22, 2024 · 0 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@alonfnt
Copy link
Owner

alonfnt commented Jul 22, 2024

Currently, making regions finite only changes voronoi.regions and voronoi.vertices. If we were to update the ridges too, then our resulting BoundedVoronoi object would also be compatible with scipy's voronoi_plot_2d, as well being more consistent.

It only requires to do some bookkeeping at BoundedVoronoi._make_regions_finite() to add the new ridges.

The boundary ridges, which are composed of 2 elements from the bounding polygon, may include the same point twice (inner Voronoi node) to avoid the infinite trick on the plotting function.

Suggestions are welcome.

@alonfnt alonfnt added enhancement New feature or request good first issue Good for newcomers labels Jul 22, 2024
@alonfnt alonfnt added this to the 0.2 milestone Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant