Skip to content
This repository has been archived by the owner on Nov 21, 2024. It is now read-only.

Add Content-Disposition Header to file download #341

Open
temparus opened this issue Jan 21, 2019 · 0 comments
Open

Add Content-Disposition Header to file download #341

temparus opened this issue Jan 21, 2019 · 0 comments

Comments

@temparus
Copy link
Member

We should add the Content-Disposition header for the media endpoint. This allows us to suggest a filename to the browser for saving. If a user wants to save a file, it just takes the file id as the file name (without any file ending).

I would suggest that we add the following header:

Content-Disposition: inline; filename="myfile.txt"

The media endpoint [1] is handled completely by Python Eve. Changing this part of the Eve Framework would be necessary.

[1] https://github.com/pyeve/eve/blob/b5ca5ce8d91cb2081eaf5c14ff2e6676c12c73e6/eve/endpoints.py#L182

@temparus temparus added this to the Version 3.0 milestone Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant