Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloading, completing + uploading template didn't work #66

Closed
ridderl opened this issue Jun 6, 2016 · 17 comments
Closed

Downloading, completing + uploading template didn't work #66

ridderl opened this issue Jun 6, 2016 · 17 comments

Comments

@ridderl
Copy link

ridderl commented Jun 6, 2016

  • Select AVLT + [Next] + Download template
  • Result:
Demographics
id
age
sex
education
AVLT-total_1_to_5
AVLT-delayed_recall_1_to_5
AVLT-recognition_1_to_5
  • Completed the template:
Demographics,Patient 1
id,2
age,45
sex,male
education,Verhage 2
AVLT-total_1_to_5,40
AVLT-delayed_recall_1_to_5,20
AVLT-recognition_1_to_5,10
  • Uploaded it to the website
  • Result:
    • Browse button for uploading is then missing
    • Empty table, with additional fields instead of filled cells:
Demographics
id
age
birthdate
testdate
sex
education
AVLT-total_1_to_5
AVLT-delayed_recall_1_to_5
AVLT-recognition_1_to_5
AVLT-total_1_to_5,40
AVLT-delayed_recall_1_to_5,20
AVLT-recognition_1_to_5,10
@anandgavai
Copy link
Member

The uploading of data has been changed from "," separated values to Dutch standard ";" separated values.

@ridderl
Copy link
Author

ridderl commented Jun 6, 2016

Ah, indeed with ; instead of , it works OK. But, I guess we want this to work with comma separated files as well?
Also, after the upload, the button for (another) upload is gone. Is that on purpose?

@ridderl
Copy link
Author

ridderl commented Jun 6, 2016

Also, the sex and education cells were still not filled

@anandgavai
Copy link
Member

Sex needs to be 0, 1 and education needs to be values between 1 till 7 . The upload button was gone on request as it was a two step procedure, but will make it more clear.

@ridderl
Copy link
Author

ridderl commented Jun 6, 2016

  • OK, that works. Bottom line is that this needs to be clear for the user. (Maybe some explanation in the excel file? Ask Nathalie?)
  • Download after filling the table online does not include the filled in data ...

@anandgavai
Copy link
Member

anandgavai commented Jun 6, 2016

. @Nanouk123 is working on text for every tab and it will be made clear by me on the selection as well !
. Download after filling the table functionality never existed. It is only for creating the template to be filled in by the clinician

@mkuzak
Copy link
Member

mkuzak commented Jun 8, 2016

@ridderl this should work now (in running cloud instance) please confirm and close if you think it's resolved.

@ridderl
Copy link
Author

ridderl commented Jun 8, 2016

No, it doesn't work properly yet:

  • If you download the template twice, the second time it is different from the first time (doubling the rows).
  • Do we still expect the template to include completed testscores? At this moment it doesn't (If you first go Next, fill in some values, then go Previous and then download the template), but I thought we wanted to have the possibility to download the table including the completed scores. Therefore I thought it would be most logical to have the upload button on the first "tab" and the download button on the second.

@mkuzak
Copy link
Member

mkuzak commented Jun 8, 2016

Agree, does not work yet. @Nanouk123 do we want to be able to download template with filled in values?

@anandgavai
Copy link
Member

If we want to have downloaded values then may be we can put this in a new requirement list ? @ridderl @Nanouk123 please confirm

@Nanouk123
Copy link

@mkuzak at some point we do want to download the excel files with the values. Because then clinicians can store them with their results and reupload them later (that's why we have the 'upload template' in the first tab for these exact people).

I think some of these points overlap my comments on andi-nl/andi#18 (comment) ?

@mkuzak
Copy link
Member

mkuzak commented Jun 8, 2016

@Nanouk123 @anandgavai @ridderl It's clear that this is a requirement then.

@Nanouk123
Copy link

Yes, it already was in the beginning (idealy we wanted to export PDF with the results (plots) and automatically download the csv for the uploaded patient(s). This because we want clinicians to re-evaluate the patient data. But it was too much work and ethically difficult to instate a log in system in which clinicians could save the patient data they have filled out in earlier sessions.

So to avoid all that (you need permission from patients to keep their data online, security issues and such) we agreed that in the export you'd always include the excel/csv with the filled out data. So that for a next session they can quickly upload the file.

Does that make sense?

@mkuzak
Copy link
Member

mkuzak commented Jun 8, 2016

It does.

@anandgavai
Copy link
Member

anandgavai commented Jun 9, 2016

@Nanouk123 @ridderl If we would like to download template filled with values this would mean a lot of restructuring of the code !!!

@Nanouk123
Copy link

This was already a requirement in the first version. We can discuss it later today if you wish.

@mkuzak
Copy link
Member

mkuzak commented Jul 1, 2016

This has been fixed or changed. Downloading data goes into the new tab. Template should always be empty.

@mkuzak mkuzak closed this as completed Jul 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants