Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themed Widgets #15084

Open
danielmehring opened this issue Dec 25, 2023 · 7 comments · May be fixed by #17654
Open

Themed Widgets #15084

danielmehring opened this issue Dec 25, 2023 · 7 comments · May be fixed by #17654
Labels
Accepted Maintainers welcome a PR implementing this feature

Comments

@danielmehring
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Themed widgets would provide a cleaner look on the home screen.

Describe the solution you'd like
Remaining the existing widgets and adding two more themed ones.

Additional context
So here's how it looks right now:
Screenshot_20231225-150832
Screenshot_20231225-150843

And here is a little markup how it would look:
Sketch Darkmode
Sketch Lightmode

I would love to implement this :)

Copy link

welcome bot commented Dec 25, 2023

Hello! 👋 Thanks for logging this issue. Please remember we are all volunteers here, so some patience may be required before we can get to the issue. Also remember that the fastest way to get resolution on an issue is to propose a change directly, https://github.com/ankidroid/Anki-Android/wiki/Contributing

@mikehardy
Copy link
Member

If I am correct, is this effectively implementing Material3 / Material You into the app / widget launcher icons?

That's something we should do I think, but I'm not sure how large of a change it is. I know @BrayanDSO has been steadily moving theming / theme improvements forward, so he may have already thought about this and may have ideas

If I'm correct that this is effectively system theming implementation for new theme features available in Android then I like the idea, if this is something that goes past Android theming then I'm less interested in the idea as custom / extra items quickly become a maintenance burden going forward and I resist adding things like that pretty strongly as we have limited maintenance resources vs current maintenance load

@BrayanDSO
Copy link
Member

Coloring widgets with Material You colors is possible, yes. About my Material work, I'm waiting for 2.17 to be launched before I start the disruptive changes.


But this issue can be fixed already by anyone that wants to do the job (I'm personally not motivated to do this since I don't use themed icons)

Note: for anyone that wants to tackle this, the Add note widget have a lower priority because people using Android 7.1+ can use the Add shortcut, so the widget will probably be removed when we reach minSdk = 25.

@BrayanDSO BrayanDSO added the Accepted Maintainers welcome a PR implementing this feature label Dec 26, 2023
@goodbird2
Copy link

如果能添加「统计」的任意的同步数据到桌面, 也许能令我更有动力.

@danielmehring
Copy link
Contributor Author

danielmehring commented Dec 26, 2023

I will to do it

@danielmehring
Copy link
Contributor Author

I won't keep working on it, I'm sorry!

@danielmehring danielmehring removed their assignment Feb 5, 2024
@neeldoshii
Copy link
Contributor

I am taking it up

@Rdkang Rdkang linked a pull request Dec 24, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Maintainers welcome a PR implementing this feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants