How to contribute code to this repository? #236
augustinosusky
started this conversation in
Show and tell
Replies: 1 comment
-
Hello, |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hello,
I haven't ever contributed to the publicly available project and I am not sure how to offer my code. Basically my issue was that my company is using API gateway which tracks all the API requests used in our network and they do it by custom attribute in header request. Since I very much like this collection I was not very fond of programming/constructing my API requests from scratch and I rather took a look at your collection and found out that custom header attributes could be easily added by updating:
shared specification in "plugins/module_utils/arguments.py"
support for custom headers in "plugins/module_utils/client.py" (specifically in init and request methods)
almost all rst documents in docs folders
It seems to be working fine, my test queries against development instance in service now go through.
Now I have few questions:
How would I submit my code for review?
How should I create test scenarios for this? It is not related to the modules, it is general instance attribute used in all modules.
Should I run integration and unit tests myself? (some of them were failing even before I started adding things, some of them took ages to complete)
Can you please help me understanding this?
Thank you!
Augustin
Beta Was this translation helpful? Give feedback.
All reactions