-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spec: remove the JSON spec for content file and file scan task sections #9771
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, as discussed on the dev list.
@stevenzwu: could you please link the dev list discussion to the PR for future reference?
Hey I am just back from my leave, sorry for the late review. Why not just remove these sections completely? The JSON serialization of ContentFile and FileScanTask needs to evolve in a backwards compatible way I think that is for sure, but it is at this point not something relevant with the core table spec, but more of an engine feature implementation detail right? |
They shouldn't be part of the core table spec although the JSON serializer is valuable for FileScanTask serialization. See discussion thread for more context: https://lists.apache.org/thread/2ty27yx4q0zlqd5h71cyyhb5k47yf9bv
done. let me also raise a vote thread for spec change. |
…ns. (apache#9771) They shouldn't be part of the core table spec although the JSON serializer is valuable for FileScanTask serialization. See discussion thread for more context: https://lists.apache.org/thread/2ty27yx4q0zlqd5h71cyyhb5k47yf9bv
…ns. (apache#9771) They shouldn't be part of the core table spec although the JSON serializer is valuable for FileScanTask serialization. See discussion thread for more context: https://lists.apache.org/thread/2ty27yx4q0zlqd5h71cyyhb5k47yf9bv
replaced with link to Java implementation and note for additional context.
See the discussion thread on dev mailing list.
https://lists.apache.org/thread/2ty27yx4q0zlqd5h71cyyhb5k47yf9bv