Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SonataFlowPlatform Actions and Reconciler to avoid object updates during the reconciliation #538

Open
ricardozanini opened this issue Sep 20, 2024 · 0 comments
Assignees

Comments

@ricardozanini
Copy link
Member

Description

Currently, we call the function CreateOrUpdateWithDefaults from actions called during the reconciliation algorithm.

This function updates the SonataFlowPlatform object in the cluster. By the end of the reconciliation phase, we will have updated the object again. This redundancy must be gone.

Additionally, the Monitor action will never be called since the Service action is called before it and doesn't change the object status to a phase where the monitor action can be performed.

Implementation ideas

  • Review the reconciliation logic to read the status field and set Reason and Status conditions aligned with each action
  • Update the SonataFlowPlatform only by the end of the reconciliation logic
  • Break and rename the services reconciliation logic accordingly. Today, everything is within the k8s.go file, which makes maintenance a pain.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant