Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-11816. Ozone stream to support Hsync,Hflush. #7592

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

ashishkumar50
Copy link
Contributor

What changes were proposed in this pull request?

Support Ozone Streaming work with HSync and Hflush.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-11816

How was this patch tested?

New integration test and existing test

Copy link
Contributor

@jojochuang jojochuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I think this is mostly good at least functionally. Performance will require similar changes following what was implemented in BlockOutputStream.

"KeyOutputStream should support hflush()!");
assertTrue(os.hasCapability(StreamCapabilities.HSYNC),
"KeyOutputStream should support hsync()!");
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
os.hsync();
}

Copy link
Contributor

@jojochuang jojochuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jojochuang jojochuang marked this pull request as ready for review January 8, 2025 23:38
@jojochuang jojochuang merged commit 93dab91 into apache:master Jan 9, 2025
54 checks passed
@jojochuang
Copy link
Contributor

Thanks @ashishkumar50 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants