From 192bf57ed56971168e432e3be3c3fd9208304a89 Mon Sep 17 00:00:00 2001 From: chenhang Date: Fri, 1 Dec 2023 14:39:53 +0800 Subject: [PATCH 1/2] Enable reorder read sequence for bk client by default --- conf/bookkeeper.conf | 3 +++ conf/broker.conf | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/conf/bookkeeper.conf b/conf/bookkeeper.conf index 9da459d576e11..548ece01b842d 100644 --- a/conf/bookkeeper.conf +++ b/conf/bookkeeper.conf @@ -255,6 +255,9 @@ rereplicationEntryBatchSize=100 # Enable/disable having read operations for a ledger to be sticky to a single bookie. stickyReadSEnabled=true +# Enable/disable reordering read sequence on reading entries. +reorderReadSequenceEnabled=true + # Auto-replication # The grace period, in milliseconds, that the replication worker waits before fencing and # replicating a ledger fragment that's still being written to upon bookie failure. diff --git a/conf/broker.conf b/conf/broker.conf index 6bef17350eee4..5c3afa73fa2d9 100644 --- a/conf/broker.conf +++ b/conf/broker.conf @@ -1015,7 +1015,7 @@ bookkeeperClientMinNumRacksPerWriteQuorum=2 bookkeeperClientEnforceMinNumRacksPerWriteQuorum=false # Enable/disable reordering read sequence on reading entries. -bookkeeperClientReorderReadSequenceEnabled=false +bookkeeperClientReorderReadSequenceEnabled=true # Enable bookie isolation by specifying a list of bookie groups to choose from. Any bookie # outside the specified groups will not be used by the broker From 097a707b280e78325dce65a0c44b5d1fb1219535 Mon Sep 17 00:00:00 2001 From: Jiwe Guo Date: Mon, 4 Dec 2023 10:22:25 +0800 Subject: [PATCH 2/2] fix --- .../java/org/apache/pulsar/broker/ServiceConfiguration.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java b/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java index 06d26ad680873..953902a0d7aa2 100644 --- a/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java +++ b/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java @@ -1757,7 +1757,7 @@ The delayed message index time step(in seconds) in per bucket snapshot segment, @FieldContext( category = CATEGORY_STORAGE_BK, doc = "Enable/disable reordering read sequence on reading entries") - private boolean bookkeeperClientReorderReadSequenceEnabled = false; + private boolean bookkeeperClientReorderReadSequenceEnabled = true; @FieldContext( category = CATEGORY_STORAGE_BK, required = false,