Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Redundant Annotation Setup During Cluster Restoration #8866

Open
shanshanying opened this issue Jan 23, 2025 · 0 comments
Open
Assignees
Labels
kind/enhancement New feature or request
Milestone

Comments

@shanshanying
Copy link
Contributor

shanshanying commented Jan 23, 2025

Context

When restoring a cluster from a backup, users are required to manually specify the kubeblocks.io/restore-from-backup annotation in the cluster CR.
However, certain fields within this annotation (e.g., EncryptedSystemAccount) appear to duplicate information already stored in the backup object's kubeblocks.io/encrypted-system-accounts annotation.

Problem

The current implementation forces users to:

  • Manually copy system account details from the backup's annotation

  • Maintain consistency between two separate annotations

But this creates unnecessary complexity and is error-prone.

Proposed Improvement

Automatically inherit EncryptedSystemAccount, if not specified, from the backup's kubeblocks.io/encrypted-system-accounts annotation during restoration, eliminating manual setup of redundant fields.

@shanshanying shanshanying added the kind/enhancement New feature or request label Jan 23, 2025
@shanshanying shanshanying self-assigned this Jan 23, 2025
@shanshanying shanshanying changed the title [Improvement] KB should Annotate EncryptedSystemAccount Info While Restoring From given Backup [Improvement] Redundant Annotation Setup During Cluster Restoration Jan 23, 2025
@shanshanying shanshanying added this to the Release 1.0.0 milestone Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants