Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (kakarot connectors): add kakarot svg to EVM wallet icons to hint user that the wallets are interacting with kakarot middlewares and not native Starknet #534

Open
Eikix opened this issue Nov 21, 2024 · 0 comments

Comments

@Eikix
Copy link
Contributor

Eikix commented Nov 21, 2024

for Kakarot Connectors -> Take the Wallet Icon and add a Kakarot smaller icon like done by Dynamic on fibrous.finance for metamask-starknet;

Example:
image

basically here do some SVG magic to superpose our logo to the ethprovider detail icon SVG:
https://github.com/apibara/starknet-react/blob/main/packages/kakarot/src/kakarot.ts#L94-L97

Definition of done:
When I open the wallet list, if Kakarot connectors are included,
Then I see the list of EVM wallets with each of them the logo of Kakarot placed in the down right corner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant