Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

language selection is broken #3774

Open
ilarimikkonen opened this issue Aug 30, 2019 · 3 comments · May be fixed by #3781
Open

language selection is broken #3774

ilarimikkonen opened this issue Aug 30, 2019 · 3 comments · May be fixed by #3781

Comments

@ilarimikkonen
Copy link
Member

ilarimikkonen commented Aug 30, 2019 •
edited
Loading

how to repro:
change language to "suomi"

actual: language is still engrish

expected: languages changes to finnish (suomi)

TypeError: Session.update is not a function from language.js
@ilarimikkonen
Copy link
Member Author

meteor/meteor#9918

@ilarimikkonen
Copy link
Member Author

Session.get('lang'); returns 'en' in apinf.io, but in 0.60.0 returns undefined, so meteor update regression?

@ilarimikkonen
Copy link
Member Author

root cause: code was using (non existing) session.Update() method. need to change to session.set()

ilarimikkonen added a commit that referenced this issue Aug 30, 2019
@ilarimikkonen
fix to #3774 and initial localisations
7dd0135
@ilarimikkonen ilarimikkonen linked a pull request Oct 11, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix/language change fix+german localisations apinf/platform
1 participant
@ilarimikkonen