Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting a persisted object does not recursively delete all the descendants in the tree #14

Open
hi-liang opened this issue Oct 7, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@hi-liang
Copy link
Member

hi-liang commented Oct 7, 2022

No description provided.

@hi-liang hi-liang self-assigned this Oct 7, 2022
@hi-liang hi-liang added the bug Something isn't working label Oct 7, 2022
@hi-liang hi-liang changed the title Deleting a persisted object does not recursively delete all the ancestors in the tree Deleting a persisted object does not recursively delete all the descendants in the tree Oct 7, 2022
@hi-liang
Copy link
Member Author

hi-liang commented Jan 9, 2025

I'm starting to think we need a separate microservice to handle specifically cleanup, both for TTL and unbounded tasks like this. While we shouldn't have an issue with circular references as each iteration removes entries referencing the previously deleted ones, this shouldn't be a potential block for more regular tasks like updating persist objects on the main persist thread.

We also don't have anything that cleans up orphans. Ideally those should be ignored by clients but it's still debris that should be cleaned out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant