Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for and all references to manifest/schema1 #968

Open
chengfang opened this issue Dec 13, 2024 · 0 comments
Open

Remove support for and all references to manifest/schema1 #968

chengfang opened this issue Dec 13, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@chengfang
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

github.com/distribution/distribution/v3/manifest/schema1 package (https://github.com/distribution/distribution/releases) has been deprecated and then removed from distribution/distribution module. In image-updater, there are several places that still use it. In order to bypass lint check, these places are annotated with //nolint:staticcheck. Once we upgrade to newer version of distribution/distribution module that no longer contains this package, these files will no longer compile.

  • pkg/registry/client.go
  • pkg/registry/client_test.go
  • pkg/registry/registry_test.go
  • pkg/argocd/update_test.go
  • registry-scanner/pkg/registry/client.go
  • registry-scanner/pkg/registry/client_test.go
  • registry-scanner/pkg/registry/registry_test.go

Describe the solution you'd like
Remove support for schema1 API and features, and remove all references to it from image-updater code base.

Describe alternatives you've considered
keep using the current version of distribution/distribution module, and unable to upgrade.

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant