Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some ads are un-muted about a second early #97

Open
ghost opened this issue Sep 9, 2017 · 8 comments
Open

Some ads are un-muted about a second early #97

ghost opened this issue Sep 9, 2017 · 8 comments

Comments

@ghost
Copy link

ghost commented Sep 9, 2017

I've been noticing that with some ads, they are unmuted for about a second before they end.

@CENGOiSM
Copy link

Do you have crossfade enabled? If yes, try again disabling it.

@ghost
Copy link
Author

ghost commented Sep 16, 2017

No, I don't have crossfade enabled:
Crossfade

@completerevolution
Copy link

I have noticed this issue today too, but only a handful of ads. I can't see (well, hear!) a pattern to report back.

@jackyliang
Copy link

I noticed this happening as well. Don't have crossfade enabled.

@liesislukas
Copy link

crossfade is off. All default settings just downloaded Spotify app and your app. Fresh install and i have this issue too. Not sure if with all ads but most for sure. You could make just not instant volume up, but volume fadeIn while it's the start of the song anyways.

Haven't done anything with swift but this seems would solve the issue:

https://stackoverflow.com/questions/39787319/add-a-delay-to-a-for-loop-in-swift

at

https://github.com/ArtemGordinsky/Spotifree/blob/ead811c2de41bbee1382dd05f8a59d1bca7a7c5d/Spotifree/SpotifyManager.swift#L112

@ghost
Copy link
Author

ghost commented Sep 30, 2017

I've tried a clean re-install (I reimaged my Mac a couple days ago) and I still have this issue.

@peteringram0
Copy link

Also getting this on version 1.6.5

@chmiiller
Copy link

this is fixed here #96 but I cannot find a release with this PR merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants