-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't update typescript to 5.7 yet as DataView's broken #5
Comments
Intellisense is still broken as fuck, but it now compiles and the linter is also okay with the recent changes. |
because of intellisense I'm locking typescript version to 5.6.3 |
XO uses typescript-eslint under the hood, so here are some issues to keep an eye out for: |
It now works with: class BinaryIO extends DataView<ArrayBuffer> {
constructor(buffer: ArrayBuffer, byteOffset?: number, byteLength?: number) {
super(buffer, byteOffset, byteLength)
this.position = 0
}
} |
I've also updated my stackoverflow answer: https://stackoverflow.com/questions/62613064/extending-dataview-in-typescript-throws-constructor-dataview-requires-new |
microsoft/TypeScript#60808
The text was updated successfully, but these errors were encountered: