Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't update typescript to 5.7 yet as DataView's broken #5

Closed
meszaros-lajos-gyorgy opened this issue Dec 18, 2024 · 8 comments
Closed

Comments

@meszaros-lajos-gyorgy
Copy link
Collaborator

microsoft/TypeScript#60808

@meszaros-lajos-gyorgy meszaros-lajos-gyorgy changed the title Don't update typescript to 5.7 yet as DataView's got broken Don't update typescript to 5.7 yet as DataView's broken Dec 18, 2024
@meszaros-lajos-gyorgy
Copy link
Collaborator Author

Intellisense is still broken as fuck, but it now compiles and the linter is also okay with the recent changes.

@meszaros-lajos-gyorgy
Copy link
Collaborator Author

because of intellisense I'm locking typescript version to 5.6.3

@meszaros-lajos-gyorgy
Copy link
Collaborator Author

XO uses typescript-eslint under the hood, so here are some issues to keep an eye out for:
xojs/xo#772
typescript-eslint/typescript-eslint#10115

@meszaros-lajos-gyorgy
Copy link
Collaborator Author

meszaros-lajos-gyorgy commented Dec 19, 2024

hovering the mouse over DataView:
image

hovering the mouse over the generic:
image

and this is the constructor:
image

and then intellisense doesn't recognise methods of DataView:
image

@meszaros-lajos-gyorgy
Copy link
Collaborator Author

vscode have been updated to 1.96.2 and now it ships with the updated lib.es2015.symbol.wellknown.d.ts file
image

@meszaros-lajos-gyorgy
Copy link
Collaborator Author

It now works with:

class BinaryIO extends DataView<ArrayBuffer> {
  constructor(buffer: ArrayBuffer, byteOffset?: number, byteLength?: number) {
    super(buffer, byteOffset, byteLength)
    this.position = 0
  }
}

@meszaros-lajos-gyorgy
Copy link
Collaborator Author

@meszaros-lajos-gyorgy
Copy link
Collaborator Author

+1 info: this is how settings.json looks like in vscode for me by default
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant