You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Not actually a bug, but error in docs (and tests/module_test/runner.js)
I was following the example snippet for runner for cypress_module_test and noticed it gave false positives when a test failed but nothing else.
If a test failed, result.status === 'finished' and one has to check the failed count, so in addition to checking status, one has to do something like
if (result.failures) {
console.error('Some tests failed')
console.error(result.message)
process.exit(1)
}
Version
Development (host) and target OS/architectures:
macos arm
Output of bazel --version:
bazel 6.2.0
Version of the Aspect rules, or other relevant rules from your WORKSPACE or MODULE.bazel file:
v0.2.0 of rules_cypress
cypress_version = "12.3.0",
How to reproduce
Add a failing cypress test to example, and notice it doesn't fail.
Any other information?
No response
The text was updated successfully, but these errors were encountered:
The existing runner.js wouldn't exit w/ a non-zero code if either a test
fails, or cypress.run threw an exception. This will handle both cases
Fixesaspect-build#44
What happened?
Not actually a bug, but error in docs (and
tests/module_test/runner.js
)I was following the example snippet for runner for
cypress_module_test
and noticed it gave false positives when a test failed but nothing else.If a test failed, result.status === 'finished' and one has to check the failed count, so in addition to checking status, one has to do something like
Version
Development (host) and target OS/architectures:
macos arm
Output of
bazel --version
:bazel 6.2.0
Version of the Aspect rules, or other relevant rules from your
WORKSPACE
orMODULE.bazel
file:v0.2.0
of rules_cypresscypress_version = "12.3.0",
How to reproduce
Any other information?
No response
The text was updated successfully, but these errors were encountered: