Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: .swcrc setting for sourceMaps not honored. #283

Open
aptenodytes-forsteri opened this issue Nov 4, 2024 · 1 comment
Open

[Bug]: .swcrc setting for sourceMaps not honored. #283

aptenodytes-forsteri opened this issue Nov 4, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@aptenodytes-forsteri
Copy link

What happened?

I set sourceMaps: "inline" in .swcrc. I compiled the code. No sourcemaps in the target.

Version

Development (host) and target OS/architectures:
Ubuntu Linux / amd64

Output of bazel --version:
bazel 7.1.1

Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file:

Language(s) and/or frameworks involved:

How to reproduce

https://github.com/aspect-build/rules_swc/pull/282

Any other information?

No response

@jbedard
Copy link
Member

jbedard commented Dec 4, 2024

FWIW this is because the swc rule needs to know the value of source_map so it can declare the swc outputs.

You are correct that the CLI arg set by the rule will override whatever is in the rc file, but I don't think we can change that. We could do the same as rules_ts and have a validation step that verifies what is in your swcrc is the same as what was passed to the rule etc, but I don't think that's essential or urgent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants