From a5c2e4d6d1fa95bf0edcc9c501fcd0c5870e9ffe Mon Sep 17 00:00:00 2001 From: Richard Janis Goldschmidt Date: Wed, 8 Jan 2025 15:08:00 +0100 Subject: [PATCH] chore(sequencer): remove misplaced logs Sequencer checks if the storage path exists and then reports on actions that it thinks what the call `cnidarium::Storage::load` will do. However, on the one hand cnidarium itself already reports that information. On the other hand, `Sequencer::run_until_stopped` is the wrong place to emit these events because it does not have authority over which actions cnidarium will take. Should the construct ever change, then the events will be immediately out of whack, which will lead to confusion. --- crates/astria-sequencer/src/sequencer.rs | 24 ++---------------------- 1 file changed, 2 insertions(+), 22 deletions(-) diff --git a/crates/astria-sequencer/src/sequencer.rs b/crates/astria-sequencer/src/sequencer.rs index 92df49d47..ca3f0fa9d 100644 --- a/crates/astria-sequencer/src/sequencer.rs +++ b/crates/astria-sequencer/src/sequencer.rs @@ -2,10 +2,10 @@ use astria_core::generated::astria::sequencerblock::v1::sequencer_service_server use astria_eyre::{ anyhow_to_eyre, eyre::{ - eyre, OptionExt as _, Result, WrapErr as _, + eyre, }, }; use penumbra_tower_trace::{ @@ -17,8 +17,8 @@ use tendermint::v0_38::abci::ConsensusRequest; use tokio::{ select, signal::unix::{ - signal, SignalKind, + signal, }, sync::{ oneshot, @@ -54,26 +54,6 @@ impl Sequencer { register_histogram_global("cnidarium_nonverifiable_get_raw_duration_seconds"); let span = info_span!("Sequencer::run_until_stopped"); - if config - .db_filepath - .try_exists() - .context("failed checking for existence of db storage file")? - { - span.in_scope(|| { - info!( - path = %config.db_filepath.display(), - "opening storage db" - ); - }); - } else { - span.in_scope(|| { - info!( - path = %config.db_filepath.display(), - "creating storage db" - ); - }); - } - let mut signals = spawn_signal_handler(); let substore_prefixes = vec![penumbra_ibc::IBC_SUBSTORE_PREFIX];