Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails with perl 5.41.3 and newer because of given/when removal #25

Open
eserte opened this issue Oct 27, 2024 · 0 comments
Open

Fails with perl 5.41.3 and newer because of given/when removal #25

eserte opened this issue Oct 27, 2024 · 0 comments

Comments

@eserte
Copy link

eserte commented Oct 27, 2024

t/25_depend_source.t fails with bleadperl like this:

# (BEGIN) Try::Tiny => 
# cwd => /tmp/mechacpan_t_TxfET38S
# Try::Tiny => 
Failed to install 2 modules
t/25_depend_source.t ....... 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 

Unfortunately there's no diagnostics here (could this be improved?). Using some printf-style debugging I found out that a t/when.t test is failing, probably one in Try-Tiny-0.24. So my guess was that this test failed due to some recent removals in bleadperl, and upgrading to the latest Try-Tiny could help. Indeed, with the following change the test again passes:

diff --git i/t/25_depend_source.t w/t/25_depend_source.t
index 95a92c4..8af0797 100644
--- i/t/25_depend_source.t
+++ w/t/25_depend_source.t
@@ -19,7 +19,7 @@ my $deplib  = 'Try/Tiny';
 my $options = {
   source => {
     $lib        => "$pwd/test_dists/$lib/$lib-1.0.tar.gz",
-    'Try::Tiny' => 'E/ET/ETHER/Try-Tiny-0.24.tar.gz',
+    'Try::Tiny' => 'E/ET/ETHER/Try-Tiny-0.32.tar.gz',
   },
 };
 
@@ -43,7 +43,7 @@ diag("Try::Tiny => $INC{'Try/Tiny.pm'}");
 }
 
 diag("Try::Tiny => $INC{'Try/Tiny.pm'}");
-is( $Try::Tiny::VERSION, '0.24', "The correct version was installed" );
+is( $Try::Tiny::VERSION, '0.32', "The correct version was installed" );
 
 chdir $pwd;
 done_testing;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant