Batch sampling improvement #1154
Open
+501
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
benjamc
requested changes
Dec 4, 2024
| # gaussian process | ||
| assert isinstance(self._model, GaussianProcess), 'Sample based estimate strategy only allows ' \ | ||
| 'GP as surrogate model!' | ||
| return self._model.sample_functions(X_test=X_running, n_funcs=1) |
There was a problem hiding this comment.
Why cannot we sample from the random forest?
| trial: self.runhistory[trial] | ||
| for trial in self.runhistory | ||
| if self.runhistory[trial].status == StatusType.RUNNING | ||
| # and runhistory.data[run].time >= self._algorithm_walltime_limit # type: ignore |
There was a problem hiding this comment.
why is this commented out / why would we need this?
If it should stay there commented, please explain why
| trial: self.runhistory[trial] | ||
| for trial in self.runhistory | ||
| if self.runhistory[trial].status == StatusType.RUNNING | ||
| # and runhistory.data[run].time >= self._algorithm_walltime_limit # type: ignore |
benjamc
approved these changes
Jan 13, 2025
|
Outstanding TODOs:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing #1152
This is the first step towards solving the batch sampling
TODO: