Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(static_centerline_generator): map_tf_generator package name needs update #9383

Merged

Conversation

Ericpotato
Copy link
Contributor

Description

map_tf_generator has been renamed to autoware_map_tf_generator.
This PR fix this bug and we got path generated successfully
see: TIER IV internal link for more details

Related links

Parent Issue:

  • Link

How was this PR tested?

Tested on psim

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 19, 2024
Copy link

github-actions bot commented Nov 19, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Ericpotato
Copy link
Contributor Author

@takayuki5168
@kosuke55
Can you have a look on this PR? Just a small fix and it requires code owner review to approve it

@Ericpotato Ericpotato enabled auto-merge (squash) November 21, 2024 09:03
@Ericpotato
Copy link
Contributor Author

@shmpwk
I have no idea about this build-and-test-differential(humble), can you have it merge or pass the test?

@shmpwk shmpwk added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 21, 2024
@shmpwk
Copy link
Contributor

shmpwk commented Nov 21, 2024

@Ericpotato
You need to set tag:run-build-and-test-differential

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.96%. Comparing base (8607045) to head (951f76f).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9383      +/-   ##
==========================================
- Coverage   28.98%   28.96%   -0.02%     
==========================================
  Files        1426     1434       +8     
  Lines      108252   108321      +69     
  Branches    41399    41402       +3     
==========================================
  Hits        31372    31372              
- Misses      73845    73914      +69     
  Partials     3035     3035              
Flag Coverage Δ *Carryforward flag
differential 9.17% <ø> (?)
total 28.98% <ø> (ø) Carriedforward from 8607045

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Ericpotato Ericpotato merged commit 3be9fd6 into autowarefoundation:main Nov 22, 2024
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants