fix(goal_planner): use departure_check_lane for path #9423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosuke55
requested review from
danielsanchezaran,
rej55,
go-sakayori,
soblin,
maxime-clem,
satoshi-ota,
shmpwk,
TakaHoribe,
takayuki5168,
tkimura4,
zulfaqar-azmi-t4,
kyoichi-sugahara and
TomohitoAndo
as code owners
github-actions
bot
added
the
component:planning
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
kosuke55
added
the
run:build-and-test-differential
kosuke55
changed the title
soblin
approved these changes
Nov 21, 2024
kosuke55
force-pushed
the
fix/departure_check_lane
branch
from
943fa4b to
3fa0451
Compare
Signed-off-by: kosuke55 <[email protected]>
kosuke55
force-pushed
the
fix/departure_check_lane
branch
from
3fa0451 to
e250800
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9423 +/- ##
==========================================
- Coverage 28.95% 28.94% -0.02%
==========================================
Files 1426 1431 +5
Lines 108251 108309 +58
Branches 41399 41397 -2
==========================================
Hits 31349 31349
- Misses 73868 73926 +58
Partials 3034 3034
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
kosuke55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 22, 2024
TetsuKawa
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 1, 2024
TetsuKawa
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
use departure_check_lane ( introduced in #8716 ) for shift/geoetric planner too.
currently pull over path with large vehicle is sometimes judged as invalid with lanedeparture check.
lane departure_check_lane is as follow.
yellow lanes are for lane departure check
Related links
How was this PR tested?
2024/11/21 https://evaluation.tier4.jp/evaluation/reports/03a71a48-7d44-536e-8020-34c7e9ed2dbf/?project_id=prd_jt
2024/11/21 https://evaluation.tier4.jp/evaluation/reports/2619a5e5-c10d-554e-9aed-3b8cb1536fb8/?project_id=prd_jt
2024/11/21 https://evaluation.tier4.jp/evaluation/reports/52631ab7-e143-5606-9c28-04f30c07d14a/?project_id=prd_jt
scenario sim
path without departure is not found and ego vehicle is stuck
lc_goal_planner-2024-11-21_17.54.26.mp4
lc_goal_planner-2024-11-21_18.12.28.mp4
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.