-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aexpect is not compatible with python2 #72
Comments
This may be not a good idea. |
Can a fix like the one in avocado-framework/avocado-vt#2821 help here? |
Also, this issue is best posted on the Avocado VT side as the newest aexpect has already dropped python 2 support. |
This doesn't work. In travis ci it uses aexpect 1.6.0, my fix needs aexpect >=1.6.1. but aexpect >=1.6.1 doesn't support python2. |
I think So whether we like it or not, your fixes can only affect python 3 now and the best we can do is localize the problem to the VT side and in particular the python 2 CI there. |
This cause travis CI failure or warning in python2.7.
Some features (e.g. v2v) depend on latest aexpect, if aexpect is less than 1.6.1, the pylink may reports errors like,
$ inspekt checkall --disable-lint W,R,C,E1002,E1101,E1103,E1120,F0401,I0011,E1003,W605 --disable-style W605,W606,E501,E265,W601,E402,E722,E741 --exclude avocado-libs,scripts/github --no-license-check
PEP8 disabled: W605,W606,E501,E265,W601,E402,E722,E741
Pylint disabled: W,R,C,E1002,E1101,E1103,E1120,F0401,I0011,E1003,W605
Pylint enabled : W0611
License check: disabled
************* Module avocado-vt.virttest.remote
E1123:132,11: wait_for_ssh_login_to_migrate: Unexpected keyword argument 'preferred_authenticaton' in function call
If bump to latest 1.6.1, the travis ci will report SyntaxError, like,
avocado-framework/avocado-vt#2811 (comment)
so it's better to fix aexpect to compatible with python2.
The text was updated successfully, but these errors were encountered: