Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add empty file to .gitignore to prevent cloning issues on Windows #32810

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

azarboon
Copy link
Contributor

@azarboon azarboon commented Jan 9, 2025

Issue # (if applicable)

Closes #32808

Reason for this change

The reason for the change is to resolve an issue encountered by some users on Windows systems, where the presence of the file packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.codepipeline-with-nested-stack.js.snapshot/cross-region-stack-123456789012 causes problems during the repository cloning process. This file is empty, and adding it to .gitignore ensures that it is ignored during the cloning process, thus preventing errors.

Description of changes

The file path packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.codepipeline-with-nested-stack.js.snapshot/cross-region-stack-123456789012 has been added to .gitignore. This ensures that the file is ignored during cloning, preventing any issues with the repository setup on Windows systems.

Describe any new or updated permissions being added

<!— What new or updated IAM permissions are needed to support the changes being introduced ? -->

Description of how you validated changes

It worked locally.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. p2 labels Jan 9, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 9, 2025 08:32
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@azarboon azarboon changed the title Add entry to .gitignore to prevent cloning issues on Windows chore(gitignore): add entry to ignore empty file causing cloning issues on Windows Jan 9, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 9, 2025 08:40

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@azarboon azarboon changed the title chore(gitignore): add entry to ignore empty file causing cloning issues on Windows chore: add empty file to .gitignore to prevent cloning issues on Windows Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.52%. Comparing base (f2ade56) to head (af806a1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32810   +/-   ##
=======================================
  Coverage   81.52%   81.52%           
=======================================
  Files         222      222           
  Lines       13715    13715           
  Branches     2417     2417           
=======================================
  Hits        11181    11181           
  Misses       2254     2254           
  Partials      280      280           
Flag Coverage Δ
suite.unit 81.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.97% <ø> (ø)
packages/aws-cdk-lib/core 82.09% <ø> (ø)

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: af806a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-codepipeline-actions: Problem Cloning the AWS CDK Repository on Windows
2 participants