Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need access to NoEcho on cfn.Response via LambdaWrap #215

Open
derickson82 opened this issue Jul 29, 2019 · 0 comments
Open

Need access to NoEcho on cfn.Response via LambdaWrap #215

derickson82 opened this issue Jul 29, 2019 · 0 comments
Labels
enhancement type/cfn issue or feature request related to the cfn package

Comments

@derickson82
Copy link

Is your feature request related to a problem? Please describe.

The cfn.LambdaWrap convenience method is very useful for creating the cfn.Response that is written back to the cloudformation s3 bucket. Unfortunately, there doesn't seem to be a way of setting the NoEcho bool on the cfn.Response when using cfn.LambdaWrap.

Describe the solution you'd like
Perhaps adding a noEcho bool to the returned tuple from the CustomResourceFunction, and then checking for that value in lambdaWrapWithClient. Not ideal because that is a breaking change.

Another option would be to have CustomResourceFunction return a Response object, instead of a tuple with the physicalResourceId and the data map. That would allow the user to populate Data,PhysicalResourceId, and NoEcho themselves, and have the boilerplate fill in the required values after. Again, this would be a breaking change.

The 2 options above would work with new function definitions of LambdaWrap, in order to maintain backwards compatibility.

Describe alternatives you've considered
The current work around is to copy the boilerplate code, and craft the Response myself.

Additional context

@bmoffatt bmoffatt added enhancement type/cfn issue or feature request related to the cfn package labels Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement type/cfn issue or feature request related to the cfn package
Projects
None yet
Development

No branches or pull requests

2 participants