Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3EventNotification is missing static factory method accepting InputStream #5773

Open
2 tasks done
nstdio opened this issue Jan 5, 2025 · 1 comment · May be fixed by #5780
Open
2 tasks done

S3EventNotification is missing static factory method accepting InputStream #5773

nstdio opened this issue Jan 5, 2025 · 1 comment · May be fixed by #5780
Assignees
@debora-ito
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue

Comments

@nstdio
Copy link

nstdio commented Jan 5, 2025

Describe the feature

It would be nice to have S3EventNotification::fromJson(java.io.InputStream) as a static method.

Use Case

To be able to create S3EventNotification instance from InputStream without instantiating S3EventNotification

Proposed Solution

To add static modifier to S3EventNotification::fromJson(java.io.InputStream). Note that strictly speaking this would be a breaking change for those uses who extend S3EventNotification and override this method. For users who just use it through instance reference it will still work but compiler would issue a warning.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

AWS Java SDK version used

2.29.35

JDK version used

openjdk version "21.0.5" 2024-10-15 LTS

Operating System and version

GNU/Linux
@nstdio nstdio added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 5, 2025
@debora-ito debora-ito self-assigned this Jan 8, 2025
@debora-ito debora-ito added p2 This is a standard priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Jan 8, 2025
@L-Applin L-Applin linked a pull request Jan 8, 2025 that will close this issue
Open
2 tasks
@debora-ito
Copy link
Member

@nstdio thank you for reporting this. A PR is in the works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@debora-ito debora-ito

Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add static modifier to S3EventNotification from method with InputStream aws/aws-sdk-java-v2
2 participants
@debora-ito @nstdio