Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nodeadm): add nodeadm config dump command #2107

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vflaux
Copy link
Contributor

@vflaux vflaux commented Jan 3, 2025

Issue #, if available: #2106

Description of changes:
Add a config dump command to nodeadm that print the resolved config to stdout.
It allow to dump as json (default) or yaml.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Testing Done
make test: ok

Tested locally with a user-data from an actual instance in a file.
go run cmd/nodeadm/main.go config dump -c file://userdata.txt

@cartermckinnon
Copy link
Member

cartermckinnon commented Jan 3, 2025

Can you add some more details about what you're trying to accomplish? edit: responded in the linked issue 👍

In general, we want folks to avoid taking a dependency on the nodeadm CLI in their user data, the NodeConfig is intended to be the API surface going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants