-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logic to allow warnings for input fields #3256
base: master
Are you sure you want to change the base?
Conversation
Build failing |
@FrancescoBorzi Works on my end. Can you please provide more information ? |
Thank you, but the failed test is intentional. |
ok, I will test this PR locally and let you know ;-) |
Thank you :) |
I also would like to mention, that this will NOT address any editors. The example I added for the maxLevel in creature template is just for showcasing purposes of the proposed solution. The PR aims to provide an easy framework to add form validation, not to add form validation everywhere it is needed. This needs to happen gradually, otherwise this will be a gigantic PR, considering Item Template and Creature Template have to change along with a lot of other forms. |
I don't dislike the approach but I am wondering if can be done only with: <input
keiraInputValidation
[formControlName]="'maxlevel'"
id="maxlevel"
type="number"
class="form-control form-control-sm"
/> Without requiring any other information or adding components, because may you can find a way to get the formcontrol from the input and you could spawn dynamically a component next to the without already writing a placeholder component Thanks by the way for implementing this proof of concept of warnings, it's a good job! |
Thank you for providing feedback. I will try to make it work. I also had a solution in mind that minimizes the changes required to all editors as this can introduce quite the overhead in work. I will explore possible solutions and hopefully something will work :) |
Does address but does not close #3236.
Tests are failing, because I dont want to fix them before this idea is either accepted or denied.
Right now, this is only working for the creature template max level field.
Feedback is welcome