Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Move database settings to config file #105

Open
AldebaraanMKII opened this issue Sep 15, 2024 · 2 comments
Open

Feature: Move database settings to config file #105

AldebaraanMKII opened this issue Sep 15, 2024 · 2 comments

Comments

@AldebaraanMKII
Copy link

Describe your feature request or suggestion in detail

There`s no reason for some of the settings to be in the database. All of it should be in the configuration file.

Describe a possible solution to your feature or suggestion in detail

No response

Additional context

No response

@kewinrausch
Copy link

I also though about it, but did not find a suitable solution for this for the configuration of the houses.
We got alliance, horde and neutral auction houses; what do you propose to handle their values?

Put alliance.XXX horde.XXX and neutral.XXX configuration inside the text file?
This seems a little ugly honestly, but if you have some feedback about it we're open to discuss them.

@Jaytapp
Copy link

Jaytapp commented Jan 4, 2025

What I would do is create a AHBaseConfig with all values in it. And after a config override for specific AH Houses for values that differ from the base

Then initialize all the AH with the AHBaseConfig values.
Then the AHHorde, AHNeutral, AHAlliance in the config file would have the config section but you only put values you want to override from the AHBaseConfig.
Then override only the values in the specific section.

That way in the config file you have:

#AHBaseConfig
AHBaseConfig.numberofitems
AHBaseConfig.etc
AHBaseConfig.etc
...

#Horde Overrides
AHHorde.valueIwanTochangeFromBase

#AllianceOverride
AHAlliance.someOtherValue

#NeutralAH
#nothing same as base

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants