Bug: High Server Time Diff

[spiffynacho]

Current Behaviour

Using the latest version of the mod is resulting in high server time diff:
Update time diff: 3194ms with 1 players online
Last 500 diffs summary:
|- Mean: 11ms
|- Median: 2ms
|- Percentiles (95, 99, max): 15ms, 16ms, 3194ms

Expected Behaviour

Time diff should be ~50 of less for maximum.
Can eliminate the issue by disabling seller on the module.

Steps to reproduce the problem

1. Enable module
2. Adjust configuration file (see attached)
3. Adjust database
   
   mod_ahbot.conf.txt

Extra Notes

Have tried adjusting the maximum items to lower amounts, but am still seeing high time diff. Have also increased MySQL cache size to try and compensate.

AC rev. hash/commit

USAGE: .server ...

Possible subcommands:
|- server corpses
|- server debug
|- server exit
|- server idlerestart ...
|- server idleshutdown ...
|- server info
|- server motd
|- server restart ...
|- server set ...
|- server shutdown ...
AC> .server debug
AzerothCore rev. 3ef1a4a22a82 2024-10-14 20:42:04 -0400 (master branch) (Win64, RelWithDebInfo, Static)
Connected players: 1. Characters in world: 1.
Connection peak: 1.
Server uptime: 7 minute(s) 3 second(s)
Update time diff: 2ms. Last 500 diffs summary:
|- Mean: 5ms
|- Median: 2ms
|- Percentiles (95, 99, max): 16ms, 19ms, 23ms
Using SSL version: OpenSSL 3.0.11 19 Sep 2023 (library: OpenSSL 3.0.11 19 Sep 2023)
Using Boost version: 1.81.0
Using CMake version: 3.27.7
Using MySQL version: 80034
Found MySQL Executable: C:/Program Files/MySQL/MySQL Server 8.0/bin/mysql.exe
Compiled on: Windows 10.0.20348
Worldserver listening connections on port %hu
Realmlist (Realm Id: 1) configured in port 8085
VMAPs status: Enabled. LineOfSight: true, getHeight: true, indoorCheck: true
MMAPs status: Enabled
maps directory located in C:/Build/bin/RelWithDebInfo/Data/maps. Total size: 291014951 bytes
vmaps directory located in C:/Build/bin/RelWithDebInfo/Data/vmaps. Total size: 658130721 bytes
mmaps directory located in C:/Build/bin/RelWithDebInfo/Data/mmaps. Total size: 2192910844 bytes
Default DBC locale: enUS.
All available DBC locales: enUS
Using World DB: ACDB 335.12-dev
Latest LoginDatabase update: 2024_01_20_00.sql
Latest CharacterDatabase update: mod_solo_craft.sql
Latest WorldDatabase update: z_filter_disabled_and_trash.sql
LoginDatabase queue size: 0
CharacterDatabase queue size: 0
WorldDatabase queue size: 0
List of enabled modules:
|- mod-ah-bot
|- mod-solo-lfg
|- mod-solocraft
|- mod-weekendbonus

Operating system

Windows Server 2022

Custom changes or Modules

mod-ah-bot
mod-solo-lfg
mod-solocraft
mod-weekendbonus

[kewinrausch]

Hi there.

Your setup is too greedy for the server resources probably. You are asking the bot to put up to 10k items in the AH and do this in batch of 10k attempts every minute or so. If you want a big AH you can keep the maxitems at 10k, but you shall configure the bot to perform smaller step to fill up the market.

I would advise tuning AuctionHouseBot.ItemsPerCycle to a much lower value. That variables is in charge of handle how many selling attempts the bots does at each cycle (1 minute less or more). If you set it to 250 or 500 it means that every minute the bot will attempt to load up to 250/500 elements in the auction house.

For a value set to 250, this means filling the market in around 40 minutes.

[spiffynacho]

I was under the impression the mod was posting 10k new items when they expired, essentially refreshing all of the postings. If it is updating every minute, it might be a good idea to add for the comment in the config for itemspercycle to specify this is how many items are posted every minute. I adjusted my config and will post an update after it's been through a few hours of posting items.

[spiffynacho]

Making the adjustment recommended did resolve the issue. Can we add the following comment for AuctionHouseBot.ItemsPerCycle?

# Number of items listed per cycle (approx. per minute) during mass operations