Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make updateNode more robust #591

Open
JannikStreek opened this issue Nov 26, 2024 · 0 comments · May be fixed by #603
Open

Make updateNode more robust #591

JannikStreek opened this issue Nov 26, 2024 · 0 comments · May be fixed by #603
Labels
enhancement New feature or request

Comments

@JannikStreek
Copy link
Member

JannikStreek commented Nov 26, 2024

Proposed feature
Currently, node updates for non existing nodes are dropped. In theory that sounds good, but in practice if the first request to add the node was dropped, every further request on that node will fail as well. We should think about creating the node instead if it does not exist during the update. Or even better: Check if an upsert logic would work: typeorm/typeorm#1090 (comment).

@JannikStreek JannikStreek added the enhancement New feature or request label Nov 26, 2024
@sorenjohanson sorenjohanson linked a pull request Dec 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant