Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare Experiments across different runs and hyper paramerters #23

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

nitish1295
Copy link
Collaborator

@nitish1295 nitish1295 commented Aug 10, 2023

Overview:

  • Instead of selecting experiments from dropdown, we now have table for selection. The table provides filters and other extra stuff for choosing specific experiments

  • Initial Landing Page
    image

  • Filter
    image

  • Select Multiple Experiments and switch among metrics using a carousel
    image

  • CSS and code formatting

  • Upgrade precommit yaml using pre-commit autoupdate due to poetry having issues with PyCQA/isort@0d219a6

Closes #19

Copy link
Member

@Dref360 Dref360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, but I would like for get_metrics to use a list of string here

}
history = {}

for id in run_id.split("--"):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not send a list of run ids?

backgroundColor: colors.primary[400],
});
useEffect(() => {
if (!isLoading && !isError && data && data.plots && data.plots.length > 0) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (!isLoading && !isError && data && data.plots && data.plots.length > 0) {
if (!isLoading && !isError && data?.plots?.length > 0) {

@@ -38,6 +38,26 @@
)


@app.get("/experimentsflat")
def get_experimentsflat() -> List[Dict[str, Any]]:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a type for the response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comparison across experiment runs and hyper parameters
2 participants