From 200eb53213b742dabd3e91f939c9a6c3940b25a4 Mon Sep 17 00:00:00 2001 From: "raja.lmsace@gmail.com" Date: Sat, 2 Mar 2024 11:28:59 +0530 Subject: [PATCH 1/2] Upcoming enrolment issue fixed and version updated. --- classes/automation/instances.php | 5 +++-- version.php | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/classes/automation/instances.php b/classes/automation/instances.php index abc5867..fb85a1e 100644 --- a/classes/automation/instances.php +++ b/classes/automation/instances.php @@ -425,6 +425,9 @@ public function find_user_completion_conditions($conditions, $instancedata, $use if ($status <= 0 ) { continue; } + + $enabled++; // Increase enabled condition count. + // Condition is only configured to verify the future enrolment. if ($status == condition_base::FUTURE && !$isnewuser) { $userenroltime = $this->get_user_enrolment_createtime($userid, $instancedata->course); @@ -435,8 +438,6 @@ public function find_user_completion_conditions($conditions, $instancedata, $use } } - $enabled++; // Increase enabled condition count. - if ($condition->is_user_completed($instancedata, $userid, $completion)) { $result++; // Increase completed condition count for this user. diff --git a/version.php b/version.php index e36b16f..161f3eb 100644 --- a/version.php +++ b/version.php @@ -25,7 +25,7 @@ defined('MOODLE_INTERNAL') || die(); $plugin->component = 'mod_pulse'; -$plugin->version = 2023100706; +$plugin->version = 2023100707; $plugin->requires = 2022112800; // Requires Moodle 4.1 $plugin->release = 'v2.0'; $plugin->maturity = MATURITY_STABLE; From 4745b8cdb2aaa05e1e12469ab5f01fa1800cbf15 Mon Sep 17 00:00:00 2001 From: Stefan-Alexander Scholz Date: Sat, 2 Mar 2024 17:51:36 +0100 Subject: [PATCH 2/2] Update moodle-ci.yml --- .github/workflows/moodle-ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/moodle-ci.yml b/.github/workflows/moodle-ci.yml index a6674b1..ab06012 100644 --- a/.github/workflows/moodle-ci.yml +++ b/.github/workflows/moodle-ci.yml @@ -30,6 +30,9 @@ jobs: fail-fast: false matrix: include: + - php: '8.1' + moodle-branch: 'MOODLE_403_STABLE' + database: 'pgsql' - php: '8.0' moodle-branch: 'MOODLE_402_STABLE' database: 'pgsql' @@ -42,9 +45,6 @@ jobs: - php: '7.4' moodle-branch: 'MOODLE_401_STABLE' database: 'pgsql' - - php: '7.4' - moodle-branch: 'MOODLE_400_STABLE' - database: 'mariadb' steps: - name: Check out repository code