Skip to content
This repository has been archived by the owner on Dec 27, 2022. It is now read-only.

reply visibility #24

Closed
rdela opened this issue Jan 16, 2018 · 3 comments
Closed

reply visibility #24

rdela opened this issue Jan 16, 2018 · 3 comments

Comments

@rdela
Copy link

rdela commented Jan 16, 2018

#20 (comment)

didn't account for replies to people you don't follow. Added to the TODO list!

dat://fritter.hashbase.io/thread/dat://6348fac3c70e916885ead7dce6927f01e02c0efd1a9273849891c23b7e7bac4d/posts/0jcgk0s2p.json

what you'll see if you don't follow the source

dat://fritter.hashbase.io/thread/dat://6e96b27838c76991ac3563f729beb7c6e6c362fe369793784cd1c729b2b37299/posts/0jcgjwrvg.json

example

@rdela
Copy link
Author

rdela commented Jan 16, 2018

seems like this is not retroactive either, maybe that is expected: I follow Hypercubed now but this still looks the same

@Hypercubed
Copy link
Contributor

Does it have something to do with the dat network peer connections? I can trace back some replies to threads that do not exist.

@pfrazee
Copy link
Member

pfrazee commented Jan 24, 2018

This is not a difficult bug to solve, it's just that Tara and I have been wrapped up Beaker work so we haven't hit it yet. There's really two things that need to happen:

  1. If the reply parent is not in the cache, display something temporarily so we at least know it's a reply. "Replied to this message" or something like that.
  2. (If we want) try to fetch missing parent posts and then render them.

Not necessarily sure we need to do 2 but we definitely can. 1 is the must-do and it's very easy, just some markup updates.

@rdela rdela closed this as not planned Won't fix, can't repro, duplicate, stale Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants