Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bis_boxscore.xml not available for 2019 games #118

Open
james-ingold opened this issue Apr 8, 2019 · 5 comments
Open

bis_boxscore.xml not available for 2019 games #118

james-ingold opened this issue Apr 8, 2019 · 5 comments

Comments

@james-ingold
Copy link

bis_boxscore.xml is not available for games this season. For example, this directory has no bis_boxscore.xml which is a file this library depends on to build out war: http://gd2.mlb.com/components/game/mlb/year_2019/month_03/day_29/gid_2019_03_29_anamlb_oakmlb_1/

I'm looking at working around this, but wondering if anyone has some info on why gameday at mlb.com isn't providing this file anymore?

@james-ingold james-ingold changed the title bis_boxscore.xml not available for 2019-2020 games bis_boxscore.xml not available for 2019 games Apr 8, 2019
@beanumber
Copy link
Owner

It looks like the file is now just called boxscore.xml.

  • Does it contain the same information as bis_boxscore.html?
  • Have they renamed the old files?

@james-ingold
Copy link
Author

@beanumber have you been able to use openWar for the 2019 season/is this library still maintained? I haven't been able to get the boxscore.html file to work but I haven't been able to spend enough time looking at it.

@beanumber
Copy link
Owner

I haven't been able to spend any time on it either @james-ingold. I'm guessing that it is a simple fix but it will require some digging to verify backwards compatibility.

@james-ingold
Copy link
Author

Hey @beanumber I'm trying to look into this, pulled down latest and getting
Error during wrapup: Evaluation error: object 'isBIP' not found in the makeWAR.GameDayPlays_Runs function:
bip.idx <- which(x$data$isBIP == TRUE & !is.na(x$data$our.x))

Do you know how to resolve this issue?

@gjm112
Copy link
Collaborator

gjm112 commented Jul 17, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants