Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make shakeWAR faster #42

Open
beanumber opened this issue May 28, 2015 · 2 comments
Open

make shakeWAR faster #42

beanumber opened this issue May 28, 2015 · 2 comments

Comments

@beanumber
Copy link
Owner

No description provided.

@beanumber
Copy link
Owner Author

Note that a call to shakeWAR with n resamples results in getRAA being called 2n+2 times.

owar <- shakeWAR(MayProcessed, N = 1)
...Tabulating RAA per player...
...Tabulating RAA per player...
...Tabulating RAA per player...
...Tabulating RAA per player...

The 2n is because each call to getWAR calls getRAA twice: once for the replacement-level players and once for all of the players. [Is this necessary?]

Where do the extra 2 calls to getRAA come from?

@gjm112
Copy link
Collaborator

gjm112 commented Jun 17, 2015

If the replacement data and the current year data are different, I think
you will have to call getRAA twice. If the current data is used for both
calculation and carbonising of replacement it should only call it once.
On Jun 17, 2015 1:52 PM, "Ben Baumer" [email protected] wrote:

Note that a call to shakeWAR with n resamples results in getRAA being
called 2n+2 times.

owar <- shakeWAR(MayProcessed, N = 1)
...Tabulating RAA per player...
...Tabulating RAA per player...
...Tabulating RAA per player...
...Tabulating RAA per player...

The 2n is because each call to getWAR calls getRAA twice: once for the
replacement-level players and once for all of the players. [Is this
necessary?]

Where do the extra 2 calls to getRAA come from?


Reply to this email directly or view it on GitHub
#42 (comment).

@beanumber beanumber added this to the openWAR v2.0 milestone Jan 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants