Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pending improvements in the Silhouette Computation function #171

Open
alberto-valdeolivas opened this issue Aug 17, 2021 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@alberto-valdeolivas
Copy link
Collaborator

In the silhouette_computation function there are some comments about improvements that should be made in the plots (see below). Do you plan to include this later? Or did you just forget to include these improvements?

    # TODO ADD PROPER TITLE/ AXIS/ MEAN OVERALL  and mean per label ?
    ax1 = sns.violinplot(
        y=long_df_silhouette["label"], x=long_df_silhouette["silhouette"], scale="count"
    )
    matplotlib.pyplot.close()  # Avoid plooting in function; bad practice
    silhouette_results = silhouette_in(ax1, silhouette_avg)

    return silhouette_results

Best,
Alberto

@alberto-valdeolivas alberto-valdeolivas added the enhancement New feature or request label Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant