Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIA-NN 1..8.1 vs 1.9.2 performance benchmark #453

Open
daichengxin opened this issue Dec 3, 2024 · 5 comments
Open

DIA-NN 1..8.1 vs 1.9.2 performance benchmark #453

daichengxin opened this issue Dec 3, 2024 · 5 comments

Comments

@daichengxin
Copy link
Collaborator

PXD026600 was selected as benchmark datasets (narrow window and wide window). We compared peptides and proteins identified at q-value 0.01. The peptide number has increased a little. The number of protein quantified essentially the same. It is likely that large-scale data will show the difference better, according to DIA-NN document

diann_narrow
diann_wide
diann_narrow_prot
diann_wide_prot

@ypriverol
Copy link
Member

@daichengxin thanks a lot for this great benchmark and been so quick. Im wondering the following:

  • for the new version of DIANN are we using all the parameters in the right way?
  • Are we losing some features/ids because of the parallelisation?

Im tagging @vdemichev in case he can help to find out if these are the expected results.

@vdemichev
Copy link

Seems fine I guess

@daichengxin
Copy link
Collaborator Author

We further tested the large-scale PXD030304 datasets using quantms with DIA-NN 1.8.1 and DIA-NN 1.9.2, and comparing with original paper results.

Identified #PSM

1.8.1 1.9.2 original results
252015828 285336801 204148465

Identified PSM at Global.Q.value < 0.01:
DIANN_psm_stats
quantified peptides:
DIANN_peptide_stats
quantified proteins:
DIANN_protein_stats

The quantms with DIA-NN 1.8.1 results seems to be ok and intersects well with the original results as well at peptide level. The weird thing is that 1.9.2 overlap is poor at PSM and peptide level although it identifies to more psm and peptides. Is it a change in the scan of the input spectra or something else?

@vdemichev
Copy link

Any warnings printed by 1.9.2?

@ypriverol
Copy link
Member

@daichengxin we shouldn't compute PSMs only features, please remove the PSMs concept because PSMs are difficult to figure out in the original results.

I would be interested to understand the differences in protein IDs between original results and DIANN 1.9.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants