Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n Applications #150

Open
rodvar opened this issue Jan 9, 2025 · 2 comments
Open

i18n Applications #150

rodvar opened this issue Jan 9, 2025 · 2 comments

Comments

@rodvar
Copy link
Collaborator

rodvar commented Jan 9, 2025

Apply "KEY".i18n() technique to every text that is rendered on screen.

Language to be used needs to consider languages settings persisted in user profile

As per henrik's comment

All mobile only strings should end up in the mobile resource file, and then the generate task should be run to update the kotlin files (only engl. if no translations added). We should stick to a good naming convention to keep the strings well organized with first token as general section (e.g. offerbook) then the subsection (e.g. createOffer),... and we use camelCase in bisq 2 so we should stick to same style. Basically it should follow as close as possible the bisq 2 strings convention and existing keys (e.g. if we only add one new string to an area where bisq2 strings are used we should use the same key prefixes.
@rodvar rodvar added this to the MVP Enhancements milestone Jan 9, 2025
@rodvar
Copy link
Collaborator Author

rodvar commented Jan 9, 2025

@nostrbuddha this one is on the enhancements milestone for now. If we exhaust all other possibilities and we get stuck is a good candidate to bring to MVP since i18n is very desirable and we have the major effort done already

@nostrbuddha
Copy link
Contributor

Understood. I will look at this, when I have nothing else to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants