Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading components #80

Open
nostrbuddha opened this issue Nov 27, 2024 · 4 comments
Open

Loading components #80

nostrbuddha opened this issue Nov 27, 2024 · 4 comments
Assignees
Labels

Comments

@nostrbuddha
Copy link
Contributor

Loading spinners are needed in 2 ways:

Scenario 1:

  • A listing page, where all data needs to be coming from an api call.
  • In this case, we can just pass isLoading = true and loadingWidget = {Component} to The BisqScaffold/BisqLayout classes and they take care of rendering the given component in the mid of the screen till the data arrives.

Scenario 2:

  • A form page, where all controls can be rendered initially with empty fields,
  • An overlay loader can be shown with blurred background so the form/controls are visible in the background, but cannot be interacted with
  • Once the data arrives, overlay loader is removed and the form is populated with actual data.

Even to achieve this, we set only isLoading = true to The BisqScaffold/BisqLayout classes. Without setting loadingWidget when isLoading is set to true, they show the overlay loader.

@rodvar rodvar added the UI label Nov 28, 2024
@rodvar rodvar added this to the MVP (version 0.1.0) milestone Dec 9, 2024
@rodvar
Copy link
Collaborator

rodvar commented Dec 9, 2024

@nostrbuddha I think we can close this one

@rodvar rodvar changed the title UI: Loading components Loading components Dec 18, 2024
@rodvar
Copy link
Collaborator

rodvar commented Dec 19, 2024

maybe now? @nostrbuddha :)

I've just checked, this can be considered fix by using the component CircularLoadingImage by passing the right drawable and true to the loading effect, right?

@nostrbuddha
Copy link
Contributor Author

Yes. I will do this now.
Loading states to required screens.

@rodvar
Copy link
Collaborator

rodvar commented Jan 20, 2025

@nostrbuddha I think this can be considered done, is just a matter of applying it everywhere is needed in combination with the "is interactive" flag to block the UI whilst loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants