New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

require 'grenache-ruby-http' overrides thin gem's method #39

Open

sanemat opened this issue Apr 1, 2018 · 1 comment

Contributor

sanemat commented Apr 1, 2018

In my opinion, I think this is not a good solution.

grenache-ruby-http/lib/grenache-ruby-http.rb

Line 10 in b0bb45f

require 'grenache/http/http_server'

https://github.com/bitfinexcom/grenache-ruby-http/blob/b0bb45f5a55e365cb0c1a563d0afe2df8a7a50ed/lib/grenache/http/http_server.rb#L1-L23

Contributor

prdn commented Apr 1, 2018

@sanemat what do you suggest?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment