Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to redis-namespace gem #6

Open
pungoyal opened this issue Dec 20, 2013 · 4 comments
Open

move to redis-namespace gem #6

pungoyal opened this issue Dec 20, 2013 · 4 comments

Comments

@pungoyal
Copy link

Any specific reason for using redis gem? redis-namespace gives namespaces, which would be a useful add-on.

@bklang
Copy link
Owner

bklang commented Dec 23, 2013

No specific reason. Until you mentioned it, I had not heard of redis-namespace. As I am not familiar with the gem, would you explain why we should move to it? Will it require any API change for existing users of Lemondrop? Are there any pitfalls of which we should be aware? Perhaps we could allow Lemondrop users to select their Redis backend with a config option, if you feel it is important.

@pungoyal
Copy link
Author

pungoyal commented Jan 3, 2014

The only reason I raised the request is to help users namespace their redis keys. redis gem is specifically against adding the support: redis/redis-rb#222.

A lot of popular libraries (sidekiq etc) have moved to redis-namespace for the same reason.

@bklang
Copy link
Owner

bklang commented Jan 6, 2014

I'm not opposed to this, but I still don't know enough about API changes in redis-namespace gem to feel comfortable moving the default behavior. My preference would be to do this as a configurable backend, with the default being the current redis gem. Also, since I have no personal need for this, a pull request would be most helpful :)

@pungoyal
Copy link
Author

pungoyal commented Jan 6, 2014

There would be no API changes. redis-namespace delegates everything to the underlying redis object. Creating a pull request soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants