Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve signals and rendering #10

Open
wartman opened this issue Dec 1, 2024 · 0 comments
Open

Improve signals and rendering #10

wartman opened this issue Dec 1, 2024 · 0 comments

Comments

@wartman
Copy link
Contributor

wartman commented Dec 1, 2024

Right now it's possible to create signals inside the render method of components which requires the use of an "Isolate" to clean things up. This seems bad.

Instead of this, we should introduce a dev-mode check that throws at runtime if a signal is created inside a render method. We can then remove the Isolate class both from the Component implementation and from the entire codebase. The setup method and signal metadata (@:computed etc) can handle the rest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant