Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Add keyboard shortcuts to blueman #1523

Closed
1 task done
erdnaxe opened this issue Apr 22, 2021 · 9 comments · Fixed by #1982
Closed
1 task done

[Feature request] Add keyboard shortcuts to blueman #1523

erdnaxe opened this issue Apr 22, 2021 · 9 comments · Fixed by #1982
Milestone

Comments

@erdnaxe
Copy link

erdnaxe commented Apr 22, 2021

blueman: 2.1.4
BlueZ: 5.55
Distribution: NixOS 20.09
Desktop environment: i3+XFCE

Currently to close Blueman "Bluetooth Devices" window I need to input ALT+A then E. Would it be possible to bind at least some "exit" shortcuts such as ESC, CTRL-Q or CTRL-W?

This is also problematic with the "Plugins" and "Bluetooth Adapters" windows witch are impossible to close on i3.

@cschramm
Copy link
Member

#1406 added support for CTRL-Q and CTRL-W. It's in master and will be part of 2.2.

@erdnaxe
Copy link
Author

erdnaxe commented Apr 24, 2021

Oh I was not aware of #1406, this is nice.
Does #1406 only apply to the main window, or also to "Plugins" and "Bluetooth Adapters" windows?

@cschramm
Copy link
Member

Unfortunately not. It only applies to blueman-manager. The plugin dialog is part of blueman-applet and the adapters are blueman-adapters. It would be the same logic for blueman-adapters but blueman-applet is not a GtkApplication, so it does not have the same set_accels_for_action method.

@erdnaxe
Copy link
Author

erdnaxe commented Apr 25, 2021

This is also problematic with the "Plugins" and "Bluetooth Adapters" windows witch are impossible to close on i3.

It is much less problematic as I don't open these windows everyday, but I believe it is still an issue.
Feel free to change the title/close this issue if you think this should not be fixed.

@cschramm
Copy link
Member

As I said, it's trivial for blueman-adapters, so I guess it's worth it. Regarding blueman-applet we'd have to switch it to GtkApplication to get the same. I'm not sure if @infirit had any specific reason not to use it in #1304.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@infirit
Copy link
Contributor

infirit commented Nov 10, 2021

As I said, it's trivial for blueman-adapters, so I guess it's worth it. Regarding blueman-applet we'd have to switch it to GtkApplication to get the same. I'm not sure if @infirit had any specific reason not to use it in #1304.

Short answer, there was no need for what GtkApplication provides over GApplication. It should be trivial to make it GtkApplication though.

@cschramm cschramm added this to the 2.4 milestone Jun 29, 2022
@infirit
Copy link
Contributor

infirit commented Nov 24, 2022

Closing blueman-adapters with a shortcut/escape per #1946

@infirit
Copy link
Contributor

infirit commented Dec 10, 2022

I have added closing the pluginwindow, blueman-adapters and blueman-services with Ctrl+w, Escape and Ctrl+q only when we actually quit in #1927. Are there other areas that need a shortcut for blueman 2.4?

@infirit infirit linked a pull request Dec 10, 2022 that will close this issue
@infirit infirit removed a link to a pull request Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants