Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of fractional digits #70

Open
ilazaridis opened this issue May 28, 2020 · 5 comments
Open

Number of fractional digits #70

ilazaridis opened this issue May 28, 2020 · 5 comments

Comments

@ilazaridis
Copy link

ilazaridis commented May 28, 2020

Can we have up to 8 digits displayed after the decimal point ?
Currently, numbers are rounded.

@bluppfisk
Copy link
Owner

Numbers are rounded until what I consider a meaningful amount of digits. For BTC to EUR, for instance, you will merely get 2 decimal places as I cannot fathom that anyone cares how many 1000ths of a Euro their stash is worth. But for coins of a smaller value in fiat, you'll see many more decimal places automatically (up to 8 IIRC).

@SmartLayer
Copy link

SmartLayer commented Nov 20, 2020

Problem is, the meaningful number is different for different tokens.

  • The default asset loaded is the value of ETH in terms of BTC. It shows 0.027 currently. This information isn't very helpful, since it barely moves for a long time. Users would appreciate precision like 0.0278.

  • I have NEST coins which if rendered would show 0.000038BTC which would be rounded up to 0.

Didn't find any config options to change the precision.

@bluppfisk
Copy link
Owner

commit 9536ddd should address this issue. It allows you to adjust the maximum number of decimals as well as the number of significant digits in user.conf. I also set a new default of 3 significant digits. Let me know how you fare with this change :)

@SmartLayer
Copy link

Thanks but … I hope @ilazaridis would agree, that when a user is using an indicator app, he actually wasn't expecting that the settings are changed by editing user.conf. examples are fcitx (Chinese input engine), system monitor apps and flameshot. but this is better than not able to change the decimal points for sure.

@bluppfisk
Copy link
Owner

Fair enough... This is a GUI app after all. I should include a GUI for the settings. State management is horrible/absent at the moment in this application, so I'd rather set this globally than on a per-ticker basis. It will also likely not apply until the next tick comes in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants