Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is it right to fix seed? #2

Open
hea9549 opened this issue Jun 3, 2019 · 0 comments
Open

is it right to fix seed? #2

hea9549 opened this issue Jun 3, 2019 · 0 comments

Comments

@hea9549
Copy link

hea9549 commented Jun 3, 2019

in poly.go

func randomPoly(degree int) *Poly {
	coeff := make([]bls.FQ, degree + 1)
	rng := rng.NewUniformGenerator(123123421)
	for i := range coeff {
		fq:= bls.NewFQRepr(uint64(rng.Int64()))
		coeff[i] = bls.FQReprToFQ(fq)
	}
	return &Poly {
		coeff: coeff,
	}
}

you make some code like
rng := rng.NewUniformGenerator(123123421)

but according to the library specification,

rng.NewUniformGenerator(SEED)

poly.go is not test file, so I think it is not right to fix the seed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant