Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ballistic parameter to mode #80

Open
bqth29 opened this issue Oct 1, 2024 · 1 comment · May be fixed by #81
Open

Rename ballistic parameter to mode #80

bqth29 opened this issue Oct 1, 2024 · 1 comment · May be fixed by #81
Labels
breaking change A breaking change is brought by this PR refactoring Existing code is refactored (no new feature, no breaking change)
Milestone
Simulated Bifurca...

Comments

@bqth29
Copy link
Owner

bqth29 commented Oct 1, 2024

Currently, to specify whether to use Ballistic SB (bSB) or Discrete SB (dSB), the ballistic parameter must be respectively set to True or False.

However, it can seem confusing to have a ballistic parameter but not a discrete parameter. Besides, new SB modes could emerge in litterature. Thus, it could be relevant to replace the boolean ballistic parameter by a string mode parameter that would have to possible values for now: "ballistic" and "discrete".

While updating this, it could be interesting to refactor the SimulatedBifurcationEngine enum by removing the notion of heating because it is independent from the activation function of each engine. The heat would just be a parameter of the symplectic integrator.
@bqth29 bqth29 added breaking change A breaking change is brought by this PR refactoring Existing code is refactored (no new feature, no breaking change) labels Oct 1, 2024
@bqth29 bqth29 added this to the Simulated Bifurcation 2.0 milestone Oct 1, 2024
@bqth29
Copy link
Owner Author

bqth29 commented Oct 1, 2024 •
edited
Loading

engine, version or activation could also be good candidates, maybe we should vote

@bqth29 bqth29 linked a pull request Oct 7, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change A breaking change is brought by this PR refactoring Existing code is refactored (no new feature, no breaking change)
Projects
None yet
Milestone
Simulated Bifurcation 2.0
Development

Successfully merging a pull request may close this issue.

Replace ballistic by mode bqth29/simulated-bifurcation-algorithm
1 participant
@bqth29