Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package won't work with symfony/workflow < 4.1 #57

Open
kblais opened this issue Aug 21, 2019 · 2 comments
Open

Package won't work with symfony/workflow < 4.1 #57

kblais opened this issue Aug 21, 2019 · 2 comments

Comments

@kblais
Copy link

kblais commented Aug 21, 2019

While trying to figure an issue I have with the package, I realized it can't work with symfony/workflow < 4.1 since 1.3.0 because of the use of InstanceOfSupportStrategy here :

$this->registry->addWorkflow($workflow, new InstanceOfSupportStrategy($supportStrategy));

This class was introduced in symfony/workflow 4.1 to replace the now-deprecated ClassInstanceSupportStrategy.

So either we define the minimum requirement to "symfony/worflow": "^4.1", or we add a compatibility layer to check if InstanceOfSupportStrategy exists, and if not use the ClassInstanceSupportStrategy.

What do you think about this ?

@brexis
Copy link
Owner

brexis commented Aug 21, 2019

Yes, Use the previous versions before 1.3.0 for with Symfony Workflow < 4.1.

@kblais
Copy link
Author

kblais commented Aug 22, 2019

Well, then the composer.json should be updated to only use Symfony components >= 4.1, no ? Because right now, you can require the package, but it won't work (which is pretty frustrating when you think about it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants